Skip to content

PEP 838: Adding python-version to pyvenv.cfg#5040

Merged
hugovk merged 3 commits into
python:mainfrom
konsti-openai:konsti/pyvenv-cfg-python-version
Jul 16, 2026
Merged

PEP 838: Adding python-version to pyvenv.cfg#5040
hugovk merged 3 commits into
python:mainfrom
konsti-openai:konsti/pyvenv-cfg-python-version

Conversation

@konsti-openai

@konsti-openai konsti-openai commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • [] Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

Packaging track, but close enough

  • [n/a] PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Specification
    • Rationale
    • Backwards Compatibility
    • [n/a] Security Implications
    • How to Teach This
    • Reference Implementation
    • [n/a] Rejected Ideas
    • [n/a] Open Issues
    • [n/a] Acknowledgements
    • Footnotes
    • Change History
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

@konsti-openai
konsti-openai requested a review from a team as a code owner July 15, 2026 15:38
@python-cla-bot

python-cla-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

Comment thread peps/pep-0838.rst
@read-the-docs-community

read-the-docs-community Bot commented Jul 15, 2026

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #33617464 | 📁 Comparing 312bb9e against latest (8618d76)

  🔍 Preview build  

7 files changed · + 2 added · ± 5 modified

+ Added

± Modified

@konsti-openai
konsti-openai force-pushed the konsti/pyvenv-cfg-python-version branch from 7c7a974 to 49d35ed Compare July 15, 2026 19:03
@konsti-openai konsti-openai changed the title PEP 837: Adding python-version to pyvenv.cfg PEP 838: Adding python-version to pyvenv.cfg Jul 15, 2026
Comment thread peps/pep-0838.rst Outdated
Comment thread peps/pep-0838.rst Outdated
@hugovk
hugovk merged commit a5d411b into python:main Jul 16, 2026
4 checks passed
@ncoghlan

Copy link
Copy Markdown
Contributor

While it has packaging implications, this is a regular Standards track PEP for the venv module and interpreter startup, not a Packaging PEP. Accordingly, it also isn't covered by Paul's standing delegation.

@ncoghlan

Copy link
Copy Markdown
Contributor

Checking PEP 405 itself brought my attention to #2636, which misclassified PEP 405, and that is presumably the origin of this misclassification.

I was wearing my "interpreter startup configuration" core developer hat for that particular PEP rather than the packaging interoperability role that I acquired later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants